Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable stylelint-config-sass-guidelines with their new v10.0.0 release #2460

Closed
echoix opened this issue Mar 14, 2023 · 3 comments · Fixed by #2477
Closed

Reenable stylelint-config-sass-guidelines with their new v10.0.0 release #2460

echoix opened this issue Mar 14, 2023 · 3 comments · Fixed by #2477

Comments

@echoix
Copy link
Collaborator

echoix commented Mar 14, 2023

v10.0.0 is available now and supports stylelint v15: https://www.npmjs.com/package/stylelint-config-sass-guidelines/v/10.0.0
You can view the changelog here: https://github.com/bjankord/stylelint-config-sass-guidelines/blob/main/CHANGELOG.md#1000

Originally posted by @bjankord in bjankord/stylelint-config-sass-guidelines#273 (comment)

This tool had to be disabled in #2435, but now, a new release has been worked on tonight, including a fix for the incompatible stylelint. It could be re-added and look if it is still possible to install with the other packages.

@jokay
Copy link
Contributor

jokay commented Mar 22, 2023

@echoix can this error be related to this as it was working using 6.20.0 but no longer using 6.20.1?

image

.stylelintrc.json

{
  "extends": [
    "stylelint-config-standard",
    "stylelint-config-recommended-scss",
    "stylelint-config-recommended",
    "stylelint-config-rational-order"
  ],
  "customSyntax": "postcss-scss",
  "overrides": [
    {
      "files": ["**/*.{html,vue}"],
      "customSyntax": "postcss-html"
    }
  ],
  "plugin/rational-order": true,
  "plugins": [
    "stylelint-scss",
    "stylelint-order",
    "stylelint-config-rational-order/plugin"
  ]
}

@echoix
Copy link
Collaborator Author

echoix commented Mar 22, 2023

Possibly, or that the omit dev was also added at that PR to reduce node modules, in hope to have less dependencies that could conflict or have permission problems.

Does the removed package have this dependency? If it's a real dependency, @nvuillam, should we add it to stylelint in its descriptor?

@nvuillam
Copy link
Member

If new version avoids the dependency conflict with other npm packages, let's use it yes :)

nvuillam added a commit that referenced this issue Mar 26, 2023
nvuillam added a commit that referenced this issue Mar 26, 2023
* Bring back stylelint-config-sass-guidelines

Fixes #2460

* [MegaLinter] Apply linters fixes

---------

Co-authored-by: nvuillam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants