Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: minor refactorings: use &str, fix cargo clippy #91

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Nov 4, 2024

Straightforward cleanup from #83 and #87.

This also updates the Mac github actions builds to use macos-latest.

@Adamtaranto
Copy link
Collaborator

Adamtaranto commented Nov 16, 2024

In recently merged dependabot PRs the MacOS-latest actions were never returning a result and blocking automerge.

macos (macos-latest, aarch64) Expected — Waiting for status to be reported
macos (macos-latest, x86_64) Expected — Waiting for status to be reported

Problem with this commit?

They seem to work here. Maybe just need this branch merged into main?

@ctb
Copy link
Contributor Author

ctb commented Nov 17, 2024

hi adam, yes, as part of a necessary macos actions update, the names of the actions changed so I had to fiddle with the required/essential actions. If you merge this it should fix that problem.

@Adamtaranto Adamtaranto merged commit 25a219b into main Nov 17, 2024
21 checks passed
@Adamtaranto Adamtaranto deleted the minor_refactor branch November 17, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants