Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to find out about locations from file numbers #19

Closed
wants to merge 17 commits into from
Closed

Add functionality to find out about locations from file numbers #19

wants to merge 17 commits into from

Conversation

oxinabox
Copy link
Owner

We need this to be able to set break points on File+LineNumbers

@oxinabox oxinabox changed the title [WIP] Add functionality to find out about files Add functionality to find out about locations from file numbers Jan 27, 2019
@oxinabox
Copy link
Owner Author

Required for #17
I think this is good to go (passes tests locally).

@timholy would you care to take a glance over this?

I think it is suggestiver of functions that would be good to have in CodeTracking.jl.
It is using stuff from Revise and Rebuggerr

@oxinabox
Copy link
Owner Author

Contributing towards #6

breadcrumbs

timholy
timholy reviewed Jan 28, 2019
View reviewed changes
Copy link

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for sharing!

src/locate.jl Outdated Show resolved Hide resolved
src/locate.jl Outdated Show resolved Hide resolved
@oxinabox
Copy link
Owner Author

For this to come into its own it really needs a lot of other functionality, e.g. breaking midway into a function.
But for now it isn't useless in the current master, so will look at merging soon

nickrobinson251
nickrobinson251 reviewed Mar 9, 2019
View reviewed changes
Project.toml Outdated
MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09"
Mocking = "78c3b35d-d492-501b-9361-3d52fe80e533"
OrderedCollections = "bac558e1-5e72-5ebc-8fee-abe8a469f55d"
Revise = "295af30f-e4ad-537b-8983-00126c2a3abe"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally removed when doing a rm?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revolved in #23

@oxinabox oxinabox mentioned this pull request Mar 9, 2019
Merged
@oxinabox
Copy link
Owner Author

oxinabox commented Mar 9, 2019

Merged into #23.
Technically, there might be some value in merge this branch into master roughly as is.
But unless I get a request for it (which seems unlikely as I don't think anyone is using this yet?)
I am not going to bother.

@oxinabox oxinabox closed this Mar 9, 2019
@oxinabox oxinabox deleted the ox/locatinglines branch March 21, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrobinson251 nickrobinson251 nickrobinson251 left review comments

@timholy timholy timholy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxinabox @timholy @nickrobinson251