0.7 compat (attempt 3) #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
+ Coverage 63.79% 82% +18.2%
=======================================
Files 12 12
Lines 232 150 -82
=======================================
- Hits 148 123 -25
+ Misses 84 27 -57
Continue to review full report at Codecov.
|
|
I am going to hold-off on merging this til someone pokes me, |
|
and here is the poke :) I think you should remove the Manifest.toml, and just add a Project.toml Test are passing on last nightly, but I see a few warnings: Test Summary: | Pass Total
util | 5 5
Test Summary: | Pass Total
locations | 2 2
┌ Warning: `foldr(op, v0, itr)` is deprecated, use `foldr(op, itr; init=v0)` instead.
│ caller = @match(::LineNumberNode, ::Module, ::Any, ::Any) at macro.jl:54
└ @ MacroTools ~/.julia/packages/MacroTools/IEXI/src/macro.jl:54
┌ Warning: Could not resolve filename due to
└ @ DataDeps ~/.julia/dev/DataDeps/src/filename_solving.jl:14
┌ Warning: HTTP.ExceptionRequest.StatusError(404, HTTP.Messages.Response:
│ """
│ HTTP/1.1 404 Not Found
│ Cache-Control: max-age=604800
│ Content-Type: text/html
│ Date: Mon, 16 Jul 2018 09:06:21 GMT
│ Expires: Mon, 23 Jul 2018 09:06:21 GMT
│ Server: EOS (vny006/0451)
│ Vary: Accept-Encoding
│ Content-Length: 1270
│
│ """)
└ @ DataDeps ~/.julia/dev/DataDeps/src/filename_solving.jl:15
┌ Warning: falling back to using final part of remotepath
└ @ DataDeps ~/.julia/dev/DataDeps/src/filename_solving.jl:16
Test Summary: | Pass Total
main | 4 4
┌ Warning: Could not resolve filename due to
└ @ DataDeps ~/.julia/dev/DataDeps/src/filename_solving.jl:14
┌ Warning: ErrorException("PCRE.exec error: UTF-8 error: byte 2 top bits not 0x80")
└ @ DataDeps ~/.julia/dev/DataDeps/src/filename_solving.jl:15
┌ Warning: falling back to using final part of remotepath
└ @ DataDeps ~/.julia/dev/DataDeps/src/filename_solving.jl:16
Test Summary: | Pass Broken Total
filename_solving | 8 1 9
[ Info: sending all datadeps to /tmp/tmpibSaeq
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 10001 0 10001 0 0 17037 0 --:--:-- --:--:-- --:--:-- 17008
┌ Warning: Checksum not provided, add to the Datadep Registration the following hash line
└ @ DataDeps ~/.julia/dev/DataDeps/src/verification.jl:38
┌ Warning: "1f08958df70c30bbf3f7205ad5f9b2b9430e3378b4e4e6300063bd9fbd83d6e3"
└ @ DataDeps ~/.julia/dev/DataDeps/src/verification.jl:40
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 874k 100 874k 0 0 116k 0 0:00:07 0:00:07 --:--:-- 150k
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 72985 0 72985 0 0 141k 0 --:--:-- --:--:-- --:--:-- 141k
nonmentions_realDonaldTrump_poll_tweets.csv┌ Warning: broadcast will default to iterating over its arguments in the future. Wrap arguments of
│ type `x::Char` with `Ref(x)` to ensure they broadcast as "scalar" elements.
│ caller = ip:0x0
└ @ Core :-1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 % Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 28881 100 28881 0 0 62377 0 --:--:-- --:--:-- --:--:-- 62377
100 9680k 100 9680k 0 0 1447k 0 0:00:06 0:00:06 --:--:-- 1796k
┌ Warning: Checksum not provided, add to the Datadep Registration the following hash line
└ @ DataDeps ~/.julia/dev/DataDeps/src/verification.jl:38
┌ Warning: "715d99f57999dfd174baa6c32e67e5eaf438a315273c0889ac8cdbfc83421355"
└ @ DataDeps ~/.julia/dev/DataDeps/src/verification.jl:40
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 % Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 565k 100 565k 0 0 189k 0 0:00:02 0:00:02 --:--:-- 189k
100 434k 100 434k 0 0 136k 0 0:00:03 0:00:03 --:--:-- 136k
Archive: /tmp/tmpibSaeq/UCI Banking/bank.zip
inflating: bank-full.csv Archive: /tmp/tmpibSaeq/UCI Banking/bank-additional.zip
creating: bank-additional/
inflating: bank-additional/.DS_Store
creating: __MACOSX/
... |
|
Alright, I think the deprecation is not my fault. |
|
@CarloLucibello I have fixed all the warnings that matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.