Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try and use HTTP to solve the name of a non-http URL #45

Closed
wants to merge 1 commit into from

Conversation

oxinabox
Copy link
Owner

@oxinabox oxinabox commented Jun 5, 2018

This is just an Idea.

I know right now
you'll get a warning if the remote path doesn't resolve as a HTTP URL.
I've never fixed it since since no one is using DataDeps with nonHTTP.

This is the simple way to fix it.

@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #45 into master will decrease coverage by 0.13%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   64.67%   64.54%   -0.14%     
==========================================
  Files          11       11              
  Lines         218      220       +2     
==========================================
+ Hits          141      142       +1     
- Misses         77       78       +1
Impacted Files Coverage Δ
src/filename_solving.jl 95.45% <85.71%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f7759...f829f16. Read the comment docs.

@oxinabox
Copy link
Owner Author

Closed by #54

@oxinabox oxinabox closed this Jul 20, 2018
@oxinabox oxinabox deleted the ox/nonhttp branch July 20, 2018 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants