-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for asm_sym stabilization in 1.66 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahl
requested review from
pfmooney and
bnaecker
and removed request for
pfmooney
December 14, 2022 22:30
bnaecker
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most excellent! A few questions / comments around the documentation changes, but looks great.
bnaecker
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asm_sym
is stable in 1.66; woohoo!Bunch of doc cleanup with regard to required features.
CI runs for stable, stable w/o probes, recent nightly, old-ass nightly.
Fixes an issue where we were omitting the
asm
feature for an older nightly.Once 1.66 is out (tomorrow) I need to
@pfmooney and I discussed the possibility of making this a major release and of ending support for pre 1.66 releases. We decided that this version should enable post-1.66 stable use of usdt, but also let people straddle that divide with older nightlies for example. In about 3-6 months, we should target a 1.0.0 release that has an MSRV of 1.66.