server: read host CPUID values if the spec has none #844
+78
−66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cpuid
field in an instance spec's board is optional. If it isNone
, have propolis-server read bhyve's default CPUID values and insert them into the spec as though the caller had specified them. This has two benefits:Tests: cargo test, PHD, ran
cpuid
in a Debian 11 guest to check that the correct value appears in leaf 0x40000000 (and that other leaves have their expected values).Fixes #835.