Wire up viona params from illumos#16738 #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcolombo
approved these changes
Nov 19, 2024
| @@ -713,10 +713,32 @@ impl<'a> MachineInitializer<'a> { | |||
| info!(self.log, "Creating vNIC {}", device_name); | |||
| let bdf: pci::Bdf = nic.device_spec.pci_path.into(); | |||
|
|
|||
| // Set viona device params if possible | |||
There was a problem hiding this comment.
Suggested change
| // Set viona device params if possible | |
| // Set viona device params if possible. These parameters are tuned | |
| // to maximize performance when Propolis is used with OPTE in a full | |
| // Oxide deployment, though viona devices should continue to | |
| // operate normally even when OPTE is not in use. These parameters | |
| // are not guest-visible. |
|
Adding in some testing notes from this morning, I spun up a standalone omicron on OPTE's also not falling off the copied header segment and needing to pull up any packets, so it's also behaving nicely with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that illumos#16738 has landed, it'd be nice if propolis could make use of that functionality.
In
propolis-server, we set parameters in line with how we expect it to operate in the oxide rack.propolis-standaloneremains at the defaults, while allowing modification via the toml config.