-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: move migration failure injection into instance specs #809
base: gjcolombo/target-spec-from-migration-source
Are you sure you want to change the base?
server: move migration failure injection into instance specs #809
Conversation
The PHD failure here is weird. The failure is in the
We log state changes requested through the framework's VM state change functions, as well as attempts to stop a VM when it's being torn down, and I don't see anything especially suspicious preceding the VM stopping. My best guess is that there's a synchronization bug in I also can't reproduce this locally, so I've queued a rerun to see if it happens again. Could probably use some more instrumentation in the PHD VM cleanup logic in any case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Make the server get migration failure injection device configuration from an instance spec component instead of the config TOML. This is a prelude to a larger change that will make the server stop depending on config TOMLs entirely (in favor of giving clients a library they can use to convert config TOMLs to instance spec components). PHD still needs to be able to set different import/export failure settings for migration sources and targets, so add the migration failure device to the set of components that can be replaced during preamble processing. Tests: cargo test, PHD.
7db1183
to
650fca9
Compare
0ac3bf1
to
15ad57c
Compare
Stacked on #807. Related to #804.
Make the server get migration failure injection device configuration from an instance spec component instead of the config TOML. This is a prelude to a larger change that will make the server stop depending on config TOMLs entirely (in favor of giving clients a library they can use to convert config TOMLs to instance spec components).
PHD still needs to be able to set different import/export failure settings for migration sources and targets, so add the migration failure device to the set of components that can be replaced during preamble processing.
Tests: cargo test, PHD.