Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test about boot option descriptions #788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iximeow
Copy link
Member

@iximeow iximeow commented Oct 10, 2024

ensuring we don't inflict Omicron#5112 on instances due to our own changes: boot option descriptions are load-bearing, so if we've changed them make sure we think through the consequences. i'm pleasantly surprised that EfiLoadOption just.. worked here. yay.

the procedure that gets us names we see for guest disks today is a bit subtle, but i've tried to document it fully to pair with the expectation in this test.

there are also specific conditions where failing this assertion is fine - say, if we've done #787, or changed how we're processing UEFI boot variables. just, as things are right now, we're surprisingly dependent on dancing with OVMF in exactly the same way every time a guest boots.

Copy link
Contributor

@gjcolombo gjcolombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is both a good test for us to have as we (or, well, I) change how NVMe device parameters work and a great description of how our firmware image actually constructs these IDs. Assuming this still passes with the latest HEAD we should merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants