refactor(error): wrapped error responses print using debug formatting #991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
Debug formatting is preferred over Display as it will also print information about wrapped errors, including stack traces, which can make debugging much easier.
Note that this was already the case with
UnexpectedResponse
variant, this change standardises it across all error variants.Alternatives
Debug
formatting in aDisplay
implementation is a bit of an anti-pattern. TheError
type is using the same string formatting implementation for both it'sDisplay
andDebug
traits. I can split up this functionality so that theDisplay
information can be slightly less verbose if this is desired.