Basic support for vector query parameters. #872
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having to duplicate code between the required and optional branches. Reuses the variable name inside the `let Some(..)` assignment, which has an impact on the existing output.
This assumes style=form and explode=true, which is the default. Partially resolves oxidecomputer#692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a small refactor which changes generated variable names in the output.
This currently assumes explode=true, and therefore only partially resolves #692. I'm looking for some guidance on how to best improve this. The openapiv3 crate exposes
explodein its ParameterData so the necessary configuration is available, but it's unclear to me if this value is best passed separately as part of the currentOperationParameter, or withinOperationParameterKind::Query.While I have manually tested this with an endpoint another issue is the lack of a test. The
oxidecomputer/dropshotserver used in tests doesn't yet support non-scalar query parameters. Another option is to include an openapi document and verify its output, but that feels rather heavy.