Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IPv4 options #379

Closed
wants to merge 7 commits into from
Closed

Handle IPv4 options #379

wants to merge 7 commits into from

Conversation

luqmana
Copy link
Contributor

@luqmana luqmana commented Jun 16, 2023

An IPv4 header, although not common, may include some options that increase it beyond the base 20 bytes.

luqmana added 7 commits June 15, 2023 19:27
Running that test requires root. Removing it from default-members allows
running `cargo test` from the workspace root to run all the other tests
that don't require privileges.
It currently fails as expected.
@luqmana
Copy link
Contributor Author

luqmana commented Jun 16, 2023

Pulled this out into it's own draft PR because it seems to break something when testing with omicron. A basic ping works but for TCP, I see the initial SYN packet coming into the nexus zone but no corresponding SYN-ACK. Needs some more investigation.

@luqmana
Copy link
Contributor Author

luqmana commented Jul 25, 2024

All but the last commit have been merged in #378.

The surrounding code has since changed a bit and I don't recall the exact issue mentioned earlier. Gonna close this for now and track as #571

@luqmana luqmana closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant