Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly change IPv6 prefix used and update README with address mappings. #830

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

luqmana
Copy link
Contributor

@luqmana luqmana commented Mar 29, 2022

Maybe I've just been doing it wrong but I was getting annoyed with the in-repo config not matching my test env (we had some hardcoded 192.168.1.x addresses for Nexus & Sled Agent). Key insight I had was hey, we already have all this machinery for using these IPv6 local addresses, why not just use that by default.

The goal here being that one should be able to get omicron up and running without having to manually create interfaces, assign addresses or even modify the existing configs.

Also updated the README tonote what addresses correspond to what. I understand a lot of this is in flux as it gets closer to the "real" setup, but in the meanwhile why not make the on-ramp a bit easier.

Note: the fd00:1234 to fd00:1de is purely for the vanity 😛

@luqmana luqmana requested a review from smklein March 29, 2022 19:35
Copy link
Collaborator

@smklein smklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick heads up to @bnaecker + @jmpesp - this is a minor change, but I think it overlaps with your work.

README.adoc Outdated Show resolved Hide resolved
sled-agent/src/illumos/zone.rs Show resolved Hide resolved
README.adoc Show resolved Hide resolved
@jmpesp
Copy link
Contributor

jmpesp commented Mar 30, 2022

🚢

Co-authored-by: Sean Klein <[email protected]>
@luqmana luqmana merged commit 6393e31 into main Mar 30, 2022
@luqmana luqmana deleted the luqman/setup-doc branch March 30, 2022 18:56
leftwo pushed a commit that referenced this pull request Jul 15, 2023
Crucible:
Add quota to agent created datasets (#835)
Switch to building on heliosv2 (#830)
Minor clippy cleanup (#832)
Update to latest dropshot (#829)

Propolis:
The above crucible changes
Switch to building on heliosv2 (#461)
clean up cargo check/clippy errors when built with Rust 1.71 (#462)
Add some VMM_DESTROY_VM polish to bhyve-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants