[nexus] Support Bundle HTTP endpoint implementations #7187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2024
smklein
commented
Nov 28, 2024
Comment on lines
+102
to
+112
| let mut builder = Response::builder().status(response.status()); | ||
| let headers = builder.headers_mut().unwrap(); | ||
| headers.extend( | ||
| response.headers().iter().map(|(k, v)| (k.clone(), v.clone())), | ||
| ); | ||
| let body = http_body_util::StreamBody::new( | ||
| response | ||
| .into_inner_stream() | ||
| .map_ok(|b| hyper::body::Frame::data(b)), | ||
| ); | ||
| Ok(builder.body(Body::wrap(body)).unwrap()) |
There was a problem hiding this comment.
My intent here is to act as much like a transparent proxy as I can -- find the sled that should hold the bundle, and send a request there.
If it's possible to do that without these types, I'd love that.
| .await?; | ||
| let client = self.sled_client(&sled_id).await?; | ||
|
|
||
| // TODO: Use "range"? |
There was a problem hiding this comment.
Not sure how to do this with the progenitor-generated API.
I could pull out the reqwest client manually, with client.client() (names are silly) , and then I could manually construct the URL / body / headers, but... that kinda defeats the point of using progenitor, right?
That might be our only option for the moment.
smklein
force-pushed
the
support-bundle-wire-up-http-endpoints
branch
from
07be0de
to
9b2176c
Compare
smklein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 4 / ??
Implements support bundle APIs for accessing storage bundles.
Builds atop the API skeleton in:
Uses the support bundle datastore interfaces in:
Relies on the background task in:
TODO before merging: