[wicketd-client] use more replace directives #5671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
sunshowers
requested review from
jgallagher,
internet-diglett,
rcgoodfellow and
andrewjstone
sunshowers
commented
Apr 30, 2024
| @@ -400,79 +388,7 @@ mod tests { | |||
| .collect(), | |||
| external_dns_ips: value.external_dns_ips, | |||
| ntp_servers: value.ntp_servers, | |||
| rack_network_config: InternalUserSpecifiedRackNetworkConfig { | |||
There was a problem hiding this comment.
There's simply no point to this...
andrewjstone
approved these changes
Apr 30, 2024
sunshowers
deleted the
sunshowers/spr/wicketd-client-use-more-replace-directives
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to change the format of these structs slightly as part of r8 work,
and the whole process is really, unnecessarily cumbersome. It doesn't spark
joy. This is an internal API (wicket <-> wicketd) that has no cross-version
concerns in any case.