Require each NIC on an instance to be in a unique subnet #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds additional query logic the `network_interface::InsertQuery` that fails the query if the VPC Subnet for a new interface is the same as that for an existing interface on the instance. - Updates tests to conform to and verify new unique VPC Subnet behavior
|
Addresses #1162 |
smklein
approved these changes
Jun 7, 2022
- More obvious non-UUID sentinel strings in error messages - Simplify column aliases - Link to COALESCE issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network_interface::InsertQuerythatfails the query if the VPC Subnet for a new interface is the same as
that for an existing interface on the instance.