detach disks on instance delete #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookup all disks attached to an instance during instance delete, and detach them before the instance is been deleted. fixes oxidecomputer#1031
plotnick
approved these changes
May 13, 2022
plotnick
reviewed
May 14, 2022
|
|
||
| // Detach all attached disks | ||
| let disks = self | ||
| .instance_list_disks( |
There was a problem hiding this comment.
I think this may be subject to a race condition: disks could be attached between when they're listed and when they're detached, which would leave those new attachments wedged. Fixing that would require more invasive surgery, and I don't think it should block this PR from merging. It might be worth a TODO, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lookup all disks attached to an instance during instance delete, and
detach them before the instance is been deleted.
fixes #1031