Omicron setup reused dataset from an older version #1884
Comments
This was referenced Oct 28, 2022
smklein
added a commit
that referenced
this issue
Oct 30, 2022
Major changes: - Uninstallation now collects all Zpool and Zone based datasets, prompts the user, and destroys them during the uninstall process. - Adds a "-f / --force" option to "omicron-package", allowing callers to skip the new confirmation prompt. - Adds a "deactivate" command to "omicron-package". This allows callers to remove Zones and disable services, but does not delete durable configurations and storage. A caller should be able to call "deactivate" -> "activate" -> "deactivate" repeatedly without losing durable state. Minor changes: - Updates documentation for omicron-package - Improves handling of addresses deleted from `cleanup_networking_resources`, especially in cases of duplicates - Rename "filesystem" to "dataset" in functions where it's more appropriate to be generic in the context of ZFS. Fixes #1884 Part of #1119 Part of #1313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During #1880, the first issue we hit was that a reinstalled Omicron found and attempted to use a datasets for CockroachDB and Clickhouse that were left over from a previous install. I don't think this should ever come up in production, but I think we probably want to change the software to never do this anyway. In this case, we had a fully initialized CockroachDB zone (with database populated and maybe useful data in it) that we wiped with the intent to use in the new install. I don't think that's ever what we would want.
I'm not sure what the best way to avoid this is. We could have the
uninstallstep remove these datasets, and that might be a good idea for other reasons? But it seems like part of the problem here was that when RSS sent the ensure_dataset call, we found and used the old dataset. Maybe the RSS call should specify a uuid that's different each time RSS determines a plan? That way we'll never find and use and old dataset -- we'd always create a new one for the new install. (We still have to figure out what to do with the old dataset but I think that's related to a separate issue I'm about to file.)The text was updated successfully, but these errors were encountered: