Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/create_virtual_hardware.sh fails to create zpools via thing-flinger #1612

Closed
andrewjstone opened this issue Aug 17, 2022 · 2 comments
Closed

tools/create_virtual_hardware.sh fails to create zpools via thing-flinger #1612

andrewjstone opened this issue Aug 17, 2022 · 2 comments
Assignees
@andrewjstone
Labels
bootstrap services For those occasions where you want the rack to turn on development Bugs, paper cuts, feature requests, or other thoughts on making omicron development better networking Related to the networking.

Comments

@andrewjstone
Copy link
Contributor

I'm currently building out multi-node deployment capabilities via thing-flinger and realized that zpools that should have been created when create_virtual_hardware.sh ran as part of the install-prereqs command don't exist. Looking at the output of thing-flinger I noticed the following error:

 readarray -t ZPOOLS
++ grep '"oxp_' /root/omicron_staging/tools/../smf/sled-agent/config.toml
++ sed 's/[ ",]//g'
grep: can't open "/root/omicron_staging/tools/../smf/sled-agent/config.toml"

This appears to be because create_virtual_hardware.sh assumes it is running inside the omicron repo directly and has access to the smf directory which is not the case with thing-flinger.

thing-flinger deploy install does install config.toml into /opt/oxide/sled-agent/pkg, but that happens after install-prereqs.

A simple fix seems to be to just copy the config file into /root/omicron_staging/smf/sled-agent/config.toml during install-prereqs before we run create_virtual_hardware.sh.
@andrewjstone andrewjstone self-assigned this Aug 17, 2022
@andrewjstone andrewjstone added networking Related to the networking. bootstrap services For those occasions where you want the rack to turn on labels Aug 17, 2022
@andrewjstone
Copy link
Contributor Author

Fixed in a commit to #1180

@jordanhendricks jordanhendricks added the development Bugs, paper cuts, feature requests, or other thoughts on making omicron development better label Aug 11, 2023
@jordanhendricks jordanhendricks added development Bugs, paper cuts, feature requests, or other thoughts on making omicron development better and removed development Bugs, paper cuts, feature requests, or other thoughts on making omicron development better labels Sep 6, 2023
@andrewjstone
Copy link
Contributor Author

We have thankfully moved on from thing flinger.

leftwo pushed a commit that referenced this issue Jan 27, 2025
Update Propolis and Crucible
d985985 
Crucible changes are:
Allow read only activation with less than three downstairs (#1608)
Tweaks to automatic flush (#1613)
Update Rust crate twox-hash to v2 (#1547)
Remove `LastFlushAck` (#1603)
Correctly print 'connecting' state (#1612)
Make live-repair part of invariants checks (#1610)
Simplify mend region selection (#1606)
Generic read test for crutest (#1609)
Always remove skipped jobs from dependencies (#1604)
Add libsqlite3-dev install step to Github Actions CI (#1607)
Move Nexus notification to standalone task (#1584)
DTrace cleanup. (#1602)
Reset completed work Downstairs on a `Barrier` operation (#1601)
Upstairs state machine refactoring (3/3) (#1577)

Propolis changes are:
Wire up initial support for AMD perf counters
build: upgrade tokio to 1.40.0 (#836)
build: explicitly install libsqlite3-dev in CI (#834)
add JSON output format to cpuid-gen (#832)
@leftwo leftwo mentioned this issue Jan 27, 2025
Merged
leftwo added a commit that referenced this issue Jan 27, 2025
@leftwo
Update Propolis and Crucible (#7403)
eeeb429 
Crucible changes are:
Allow read only activation with less than three downstairs (#1608)
Tweaks to automatic flush (#1613)
Update Rust crate twox-hash to v2 (#1547)
Remove `LastFlushAck` (#1603)
Correctly print 'connecting' state (#1612)
Make live-repair part of invariants checks (#1610) Simplify mend region
selection (#1606)
Generic read test for crutest (#1609)
Always remove skipped jobs from dependencies (#1604) Add libsqlite3-dev
install step to Github Actions CI (#1607) Move Nexus notification to
standalone task (#1584) DTrace cleanup. (#1602)
Reset completed work Downstairs on a `Barrier` operation (#1601)
Upstairs state machine refactoring (3/3) (#1577)

Propolis changes are:
Wire up initial support for AMD perf counters
build: upgrade tokio to 1.40.0 (#836)
build: explicitly install libsqlite3-dev in CI (#834) add JSON output
format to cpuid-gen (#832)

---------

Co-authored-by: Alan Hanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewjstone andrewjstone

Labels
bootstrap services For those occasions where you want the rack to turn on development Bugs, paper cuts, feature requests, or other thoughts on making omicron development better networking Related to the networking.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewjstone @jordanhendricks