[1/n] [dropshot] combine integration tests into one binary (#1170)

This is a pattern commonly used by us and speeds up compile times, since
there's only one test binary to link.

dropshot/tests/test_config.rs → dropshot/tests/integration-tests/config.rs

@@ -16,8 +16,7 @@ use std::sync::atomic::{AtomicU16, Ordering};
 use tempfile::NamedTempFile;
 use tokio::sync::mpsc;
 
-pub mod common;
-use common::create_log_context;
+use crate::common::{self, create_log_context};
 
 // Bad values for "bind_address"
 

dropshot/tests/test_demo.rs → dropshot/tests/integration-tests/demo.rs

@@ -58,9 +58,9 @@ use tokio_tungstenite::tungstenite::Message;
 use tokio_tungstenite::WebSocketStream;
 use uuid::Uuid;
 
-extern crate slog;
+use crate::common;
 
-pub mod common;
+extern crate slog;
 
 fn demo_api() -> ApiDescription<usize> {
     let mut api = ApiDescription::<usize>::new();

dropshot/tests/test_detached_shutdown.rs → dropshot/tests/integration-tests/detached_shutdown.rs

@@ -11,7 +11,7 @@ use http::{Method, Response, StatusCode};
 use std::time::Duration;
 use tokio::sync::mpsc;
 
-pub mod common;
+use crate::common;
 
 struct Context {
     endpoint_started_tx: mpsc::UnboundedSender<()>,

dropshot/tests/integration-tests/main.rs

@@ -0,0 +1,26 @@
+// Copyright 2024 Oxide Computer Company
+
+//! Integration tests for Dropshot.
+//!
+//! These are all combined into the same file to ensure that a single binary is
+//! generated, speeding up link times.
+
+#[macro_use]
+extern crate slog;
+#[macro_use]
+extern crate lazy_static;
+
+mod api_trait;
+mod common;
+mod config;
+mod demo;
+mod detached_shutdown;
+mod multipart;
+mod openapi;
+mod pagination;
+mod pagination_schema;
+mod path_names;
+mod starter;
+mod streaming;
+mod tls;
+mod versions;

dropshot/tests/test_multipart.rs → dropshot/tests/integration-tests/multipart.rs

@@ -8,9 +8,9 @@ use dropshot::{
 };
 use http::{Method, Response, StatusCode};
 
-extern crate slog;
+use crate::common;
 
-pub mod common;
+extern crate slog;
 
 fn api() -> ApiDescription<usize> {
     let mut api = ApiDescription::new();

dropshot/tests/test_pagination.rs → dropshot/tests/integration-tests/pagination.rs

@@ -46,12 +46,7 @@ use subprocess::NullFile;
 use subprocess::Popen;
 use uuid::Uuid;
 
-#[macro_use]
-extern crate slog;
-#[macro_use]
-extern crate lazy_static;
-
-pub mod common;
+use crate::common;
 
 // Common helpers
 
@@ -571,7 +566,7 @@ lazy_static! {
 }
 
 fn make_word_list() -> BTreeSet<String> {
-    let word_list = include_str!("wordlist.txt");
+    let word_list = include_str!("../wordlist.txt");
     word_list.lines().map(|s| s.to_string()).collect()
 }
 

dropshot/tests/test_starter.rs → dropshot/tests/integration-tests/starter.rs

@@ -3,9 +3,6 @@
 //! Quick check that the "legacy" HttpServerStarter::new() and
 //! HttpServerStarter::new_with_tls() interfaces work.
 
-pub mod common;
-
-use common::create_log_context;
 use dropshot::endpoint;
 use dropshot::test_util::read_json;
 use dropshot::test_util::ClientTestContext;
@@ -17,6 +14,9 @@ use dropshot::HttpResponseOk;
 use dropshot::HttpServerStarter;
 use dropshot::RequestContext;
 
+use crate::common;
+use crate::common::create_log_context;
+
 extern crate slog;
 
 /// Test starting a server with `HttpServerStarter::new()`.

dropshot/tests/test_streaming.rs → dropshot/tests/integration-tests/streaming.rs

@@ -8,9 +8,9 @@ use http::{Method, Response, StatusCode};
 use http_body_util::BodyExt;
 use tokio::io::{AsyncSeekExt, AsyncWriteExt};
 
-extern crate slog;
+use crate::common;
 
-pub mod common;
+extern crate slog;
 
 fn api() -> ApiDescription<usize> {
     let mut api = ApiDescription::new();

dropshot/tests/test_tls.rs → dropshot/tests/integration-tests/tls.rs

@@ -13,10 +13,7 @@ use std::path::Path;
 use std::sync::atomic::{AtomicUsize, Ordering};
 use std::sync::Arc;
 
-pub mod common;
-use common::create_log_context;
-
-use crate::common::generate_tls_key;
+use crate::common::{self, create_log_context, generate_tls_key};
 
 /// See rustls::client::ServerCertVerifier::verify_server_cert for argument
 /// meanings

dropshot/tests/test_versions.rs → dropshot/tests/integration-tests/versions.rs

@@ -19,7 +19,7 @@ use serde::Deserialize;
 use serde::Serialize;
 use std::io::Cursor;
 
-pub mod common;
+use crate::common;
 
 const VERSION_HEADER_NAME: &str = "dropshot-test-version";
 const HANDLER1_MSG: &str = "handler1";