Update role assignment for /users listing silo users without names #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
added a commit
that referenced
this pull request
Jun 28, 2022
* Tweaking to match updated buttons in design system #862 * Tweak to match new taxonomy * remove @types/react-table, it was for v7 * Update role assignment for /users listing silo users without names (#981) * remove names from role assignment, use ID for everything * put back empty string as name * Reverse side modal button order (#980) * simplify SideModal.Footer * Project switcher (#973) * basic project switcher w/ ugly but liveable styling * little e2e test for the switcher * fix mysterious shrinking header space * filter out current project * Setting page title #949 (#976) * Setting page title #949 * Add react-helmet types * don't use helmet, add title checks to breadcrumbs e2e Co-authored-by: David Crespo <[email protected]> * Remove default color for form buttons * Fix button type errors Co-authored-by: David Crespo <[email protected]> Co-authored-by: David Crespo <[email protected]> Co-authored-by: Justin Bennett <[email protected]>
david-crespo
added a commit
that referenced
this pull request
Jun 28, 2022
* Underline on hover and use semibold for table links * Use abbreviated timeAgo fn @david-crespo is this okay to use? * Remove last breadcrumb item @david-crespo any unintended consequences from doing it like this? * Increase text size of pagination * Fix properties table not 50/50 * Border and spacing around more actions button * Tweak dropdown to better match Figma * Fix CI breaking - href is no longer optional * Fix react-table update breaking vercel deploy * Dropdown animation (only works on first open) * Previous class did nuffink * Bot commit: format with prettier * Tweaking to match updated buttons in design system #862 (#979) * Tweaking to match updated buttons in design system #862 * Tweak to match new taxonomy * remove @types/react-table, it was for v7 * Update role assignment for /users listing silo users without names (#981) * remove names from role assignment, use ID for everything * put back empty string as name * Reverse side modal button order (#980) * simplify SideModal.Footer * Project switcher (#973) * basic project switcher w/ ugly but liveable styling * little e2e test for the switcher * fix mysterious shrinking header space * filter out current project * Setting page title #949 (#976) * Setting page title #949 * Add react-helmet types * don't use helmet, add title checks to breadcrumbs e2e Co-authored-by: David Crespo <[email protected]> * Remove default color for form buttons * Fix button type errors Co-authored-by: David Crespo <[email protected]> Co-authored-by: David Crespo <[email protected]> Co-authored-by: Justin Bennett <[email protected]> * Fix breadcrumb tests and last crumb removal improvements * Style toast to match Figma * Increase tappable area, remove unnecessary `ox-btn` styles * Closer match to Figma input * Improve listbox styling * Better overflow behaviour for sidenav #751 * Match new navigation project switcher and handle long project names * Ensure query table gets menu classnames * Fix serial console route * Fix low contrast dropdown Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: David Crespo <[email protected]> Co-authored-by: David Crespo <[email protected]> Co-authored-by: Justin Bennett <[email protected]> Co-authored-by: Justin Bennett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oxidecomputer/omicron#1261 changes
/usersso it lists silo users instead of system users, which is what we need. The problem is those users have no names (yet). So for now instead of doing the manual association of users to names I had been doing for system users, now we just drop''in there as a placeholder and do everything by UUID. We will have names eventually.Testing against real Nexus
This change also allowed me to test that role assignment actually behaves the way you would think. Nexus by default starts out with a "privileged" user who has admin on everything and an "unprivileged" user who can't see anything. I tested the following and everything works as expected:
Pcreates org and projectUPcan't list orgs in silo, can't fetch individual org or projectPaddsUPas viewer of orgUPstill can't list orgs (this is a list children perm on the silo) but can now fetch the org directly and list projects, still can't create a project in the orgPchangesUPto collaborator on orgUPcan now create a project in the org