Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesafe handleErrors #808

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Typesafe handleErrors #808

merged 1 commit into from
Apr 17, 2022

Conversation

david-crespo
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Apr 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
console-ui-storybook ✅ Ready (Inspect) Visit Preview Apr 17, 2022 at 4:42PM (UTC)

@david-crespo
Copy link
Collaborator Author

Approval here #788 (comment)

@david-crespo david-crespo merged commit 0b04815 into form-error-msgs Apr 17, 2022
@david-crespo david-crespo deleted the handle-errors-type branch April 17, 2022 16:43
zephraph added a commit that referenced this pull request Apr 21, 2022
* Pass error down to form actions

* Move error normalization to the API package

* Remove old getServerError references

* Fix tests

* Add error to form actions

* Adjust layout for side modal, add more error messages

* Fix error positioning

* tweak styles further to remove need for spacer

* typesafe handleErrors (#808)

* automatically update packer-id

* Clean up global error handling

* remove console.log

Co-authored-by: David Crespo <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant