Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minitable to Floating IP side modal #2630

Merged
merged 9 commits into from
Jan 10, 2025

Conversation

charliepark
Copy link
Contributor

@charliepark charliepark commented Dec 18, 2024

Back in #994, Justin noted the absence of some resource details at the top of side modals. (That is, non-editable details that might pertain to the editable fields of the form.) This PR just picks up the Floating IP side modal and adds the relevant info.

Screenshot 2024-12-18 at 2 23 34 PM Screenshot 2024-12-18 at 3 38 30 PM

Well, hm. After adding all of the data (id, dates), that's an awful lot of forehead on the form. I wonder if we should put it in a pre-collapsed, expandable element

Happy to pick up more, but figured this was a tightly-scoped one.

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Jan 10, 2025 9:21pm

@david-crespo
Copy link
Collaborator

Yeah, I had the same reaction about it being a lot of noise. Collapsing it is an interesting idea. Ben will have to take a look.

@charliepark
Copy link
Contributor Author

@benjaminleonard would love your thoughts on what a collapsible implementation might look like for this header information.

@david-crespo suggests possibly using the icon and image-1 name with a dropdown?
Screenshot 2025-01-07 at 11 46 18 AM

@benjaminleonard
Copy link
Contributor

I'm not convinced making it collapsible is an improvement. I like to avoid tucking too much away because discoverability is harder and scrolling is less effort than clicking.

If we did modify this, it might be to pull the timestamps and the ID out ... possibly, but would need to play with it. I'd suggest leaving it, and if it gets worse we can reconsider.

@charliepark charliepark merged commit 6cd25c9 into main Jan 10, 2025
7 checks passed
@charliepark charliepark deleted the add_minitable_to_floatingIp_edit branch January 10, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants