-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minitable to Floating IP side modal #2630
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yeah, I had the same reaction about it being a lot of noise. Collapsing it is an interesting idea. Ben will have to take a look. |
@benjaminleonard would love your thoughts on what a collapsible implementation might look like for this header information. @david-crespo suggests possibly using the icon and |
I'm not convinced making it collapsible is an improvement. I like to avoid tucking too much away because discoverability is harder and scrolling is less effort than clicking. If we did modify this, it might be to pull the timestamps and the ID out ... possibly, but would need to play with it. I'd suggest leaving it, and if it gets worse we can reconsider. |
Back in #994, Justin noted the absence of some resource details at the top of side modals. (That is, non-editable details that might pertain to the editable fields of the form.) This PR just picks up the Floating IP side modal and adds the relevant info.
Well, hm. After adding all of the data (id, dates), that's an awful lot of forehead on the form. I wonder if we should put it in a pre-collapsed, expandable element
Happy to pick up more, but figured this was a tightly-scoped one.