-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus Exporter for Pyrometer #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the beginning of tezos-k8s we have always deployed ingresses outside of our charts. Is it the right approach? Maybe not: the default helm chart created with `helm init` has a pre-configured ingress template file. This ingress template file is sufficient for our use cases: we can pass ingress annotations and TLS configuration with values.yaml. Therefore, we add an option to define the ingress with helm directly. This allows to remove an ingress definition from the teztnets and oxheadinfra code bases, simplifying it. We should consider doing that for Tezos RPC as well.
harryttd
reviewed
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a couple of questions. Also i didn't test and am assuming it works
harryttd
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting pyrometer architecture doc:
Pyrometer is a self-sustaining tool that manages its own alerts and alerting channels. But what if I want to use it as a pure monitoring tool and and off the alert management to my prometheus stack in my kubernetes cluster?
I am introducing a Prometheus exporter for pyrometer. It consumes pyrometer events with the webhook and monitors only one of them: baker health status. It then aggregates the number of unhealthy bakers and exposes this as a prometheus metric.
The exporter is a sidecar so no modifications to pyrometer are required. The sidecar is included in the chart and relies on the utils container (just like the tezos sidecar). The ServiceMonitor and PrometheusRule are also included in the chart.
This gives you:
I also add a default config in the values.yaml. Launching the tezos chart with no parameters, and the pyrometer chart with no parameters, will result in pyrometer acting as node monitoring for the node.