Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaledpsd #131

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Scaledpsd #131

merged 2 commits into from
Jun 2, 2023

Conversation

blegat
Copy link
Contributor

@blegat blegat commented May 22, 2023

This new cone was just added in MOI v1.6. This allows simplifying the MOI wrapper of many SDP solver but it also allows passing scaled PSD cone data directly to the solver.

@CLAassistant
Copy link

CLAassistant commented May 22, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Patch coverage: 72.31% and project coverage change: -1.24 ⚠️

Comparison is base (50b0c6e) 82.22% compared to head (3853da5) 80.99%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   82.22%   80.99%   -1.24%     
==========================================
  Files          37       39       +2     
  Lines        2701     2799      +98     
==========================================
+ Hits         2221     2267      +46     
- Misses        480      532      +52     
Impacted Files Coverage Δ
src/cones/coneops_defaults.jl 15.55% <0.00%> (-7.18%) ⬇️
src/equilibration.jl 97.95% <ø> (ø)
src/precompile.jl 0.00% <0.00%> (ø)
src/settings.jl 4.44% <0.00%> (-3.56%) ⬇️
src/variables.jl 77.64% <ø> (+11.64%) ⬆️
src/version.jl 28.57% <0.00%> (ø)
src/Clarabel.jl 55.55% <42.85%> (-44.45%) ⬇️
src/utils/mathutils.jl 80.98% <50.00%> (+3.77%) ⬆️
src/types.jl 85.71% <70.00%> (-0.65%) ⬇️
src/MOI_wrapper/MOI_wrapper.jl 85.27% <91.66%> (+0.30%) ⬆️
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@goulart-paul goulart-paul merged commit c3f410e into oxfordcontrol:main Jun 2, 2023
@goulart-paul
Copy link
Member

Thanks for this - scaled PSD cone through MOI is indeed much easier on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants