Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blog content alignment #67

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Fix blog content alignment #67

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33032cd
fix: blog content alignment
Aerilym Oct 15, 2024
ffdd217
fix: remove more posts when only one post
Aerilym Oct 15, 2024
c08ff9a
fix: post full width when no headings
Aerilym Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/foundation/app/(Site)/blog/[slug]/BlogPost.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default async function BlogPost({ post }: PostProps) {
.filter(Boolean);

return (
<article className="mx-auto mb-32 mt-4 flex max-w-screen-xl flex-col">
<article className="mx-auto mb-32 mt-4 flex max-w-screen-xl flex-col items-start">
<Link href={SANITY_SCHEMA_URL.POST} prefetch>
<Button
data-testid={ButtonDataTestId.Back_To_Blog}
Expand Down
4 changes: 2 additions & 2 deletions apps/foundation/app/(Site)/blog/[slug]/HeadingOutline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type HeadingOutlineProps = {

export default function HeadingOutline({ title, headings }: HeadingOutlineProps) {
return (
<nav className="wrap sticky top-12 mt-7 hidden h-max w-max max-w-[25vw] lg:block">
<nav className="wrap sticky top-12 hidden h-max w-max max-w-[25vw] lg:block">
<Typography variant="h2" className="mb-3">
{title}
</Typography>
Expand All @@ -32,7 +32,7 @@ export default function HeadingOutline({ title, headings }: HeadingOutlineProps)
onClick={() => {
scrollToHeading(heading);
}}
className={cn(navlinkVariants({ active: false }), 'w-full text-wrap text-start')}
className={cn(navlinkVariants({ active: false }), 'w-max text-wrap text-start')}
>
{heading}
</button>
Expand Down
8 changes: 5 additions & 3 deletions apps/foundation/app/(Site)/blog/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,11 @@ export default async function BlogGridPage() {
<ReadMoreText />
</PostInfoBlock>
</Link>
<Typography variant="h2" className="mt-12">
{blogDictionary('morePosts')}
</Typography>
{rest?.length ? (
<Typography variant="h2" className="mt-12">
{blogDictionary('morePosts')}
</Typography>
) : null}
<div className="mt-4 grid grid-cols-1 gap-12 md:mt-8 md:grid-cols-3">
{rest.map((post, index) => (
<Link
Expand Down
Loading