Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the LintLocalizableStrings script #1046

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mpretty-cyro
Copy link
Collaborator

  • Added new 'LintControl' mechanisms to allow for ignoring sections of code
  • Added new 'MatchType' mechanisms for excluding unlocalized cases
  • Updated the code to explicitly handle localized template strings (both single and multiline)
  • Updated the code to process files across multiple threads to improve performance
  • Updated the code to use Swift 5.7 regex and store in static variables to prevent reconstruction every time they are used
  • Removed the list of individual files which are ignored (now just output a count)
  • Fixed an issue where having a localized string on a subsequent line could result in an unlocalized (or incorrectly localized) string not being detected
  • Fixed an issue where having multiple strings on a single line could result in an unlocalized string not being detected
  • Fixed an issue where zero-width characters would result in the variable count comparison between translations failing
  • Fixed a number of localization warnings

• Added new 'LintControl' mechanisms to allow for ignoring sections of code
• Added new 'MatchType' mechanisms for excluding unlocalized cases
• Updated the code to explicitly handle localized template strings (both single and multiline)
• Updated the code to process files across multiple threads to improve performance
• Updated the code to use Swift 5.7 regex and store in static variables to prevent reconstruction every time they are used
• Removed the list of individual files which are ignored (now just output a count)
• Fixed an issue where having a localized string on a subsequent line could result in an unlocalized (or incorrectly localized) string not being detected
• Fixed an issue where having multiple strings on a single line could result in an unlocalized string not being detected
• Fixed an issue where zero-width characters would result in the variable count comparison between translations failing
• Fixed a number of localization warnings
@mpretty-cyro mpretty-cyro requested a review from RyanRory October 17, 2024 23:21
@mpretty-cyro mpretty-cyro self-assigned this Oct 17, 2024
@mpretty-cyro mpretty-cyro merged commit ef0f73a into oxen-io:dev Oct 18, 2024
1 check passed
@mpretty-cyro mpretty-cyro deleted the fix/string-linter-issues branch October 18, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants