Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised the libSession size limit tests #1037

Merged

Conversation

mpretty-cyro
Copy link
Collaborator

@mpretty-cyro mpretty-cyro commented Oct 9, 2024

  • Optimised the libSession size limit tests
  • Tweaked another couple failing tests

Some quick stats on the differences with the updated tests using an M1 Pro:

Old New Reduction
LibSessionUtilSpec libSession, CONTACTS, when checking error catching, can catch size limit errors thrown when pushing. 9.015 seconds 1.877 seconds ~80%
LibSessionUtilSpec libSession, CONTACTS, when checking size limits, has not changed the max filled records. 3.781 seconds 1.807 seconds ~52%
LibSessionUtilSpec libSession, CONTACTS, when checking size limits, has not changed the max name and profile pic only records. 3.949 seconds 1.554 seconds ~60%
LibSessionUtilSpec libSession, CONTACTS, when checking size limits, has not changed the max name only records. 13.704 seconds 1.666 seconds ~88%
LibSessionUtilSpec libSession, CONTACTS, when checking size limits, has not changed the max empty records. 44.096 seconds 3.549 seconds ~92%

@mpretty-cyro mpretty-cyro self-assigned this Oct 9, 2024
@mpretty-cyro mpretty-cyro marked this pull request as draft October 9, 2024 22:43
@mpretty-cyro mpretty-cyro marked this pull request as ready for review October 10, 2024 02:51
@mpretty-cyro mpretty-cyro requested a review from RyanRory October 10, 2024 02:51
@mpretty-cyro mpretty-cyro merged commit 0b4629d into oxen-io:dev Oct 10, 2024
1 check passed
@mpretty-cyro mpretty-cyro deleted the feature/optimised-lib-session-size-tests branch October 10, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants