Refactor onion proxy requests to use curl multi mode #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current cpr::PostCallback approach used for proxy requests (e.g. from the last hop to a SOGS or to the big file server) runs into considerable limitations when there are more than a handful of simultaneous requests, and can encounter deadlocks with bugs in cpr's threadpool implementation. This replaces it using libcurl's single-threaded, "multi handle" approach, using our libevent event loop (from libquic) to manage the requests. This should allow more efficient requests and considerably more capacity for parallel in-progress proxied requests in each storage server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current cpr::PostCallback approach used for proxy requests (e.g. from the last hop to a SOGS or to the big file server) runs into considerable limitations when there are more than a handful of simultaneous requests, and can encounter deadlocks with bugs in cpr's threadpool implementation. This replaces it using libcurl's single-threaded, "multi handle" approach, using our libevent event loop (from libquic) to manage the requests.
This should allow more efficient requests and considerably more capacity for parallel in-progress proxied requests in each storage server.