Adds batched amounts to simplewallet balances #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcys22
force-pushed
the
wallet2-batching
branch
2 times, most recently
from
840cd35 to
37f835f
Compare
tewinget
reviewed
Jun 10, 2022
tewinget
reviewed
Jun 10, 2022
tewinget
reviewed
Jun 10, 2022
This adds detail to the balance command of the CLI wallet to show how much has been batched for each address and also summarises when the next payout is. It also includes additional fields to get_balance rpc endpoint on the oxen-wallet-rpc so the user can check on the status of their accrued funds.
darcys22
force-pushed
the
wallet2-batching
branch
from
37f835f to
90cc745
Compare
If omitted it looks up the current wallet primary address (which is usually what we want).
wallet2_api needs to provide a way to to get at this. Also changed the existing wallet_rpc_server and simplewallet code to use the new wallet2 method.
This cuts the size of the response by about 75%.
Unlike a vector, if a std::array doesn't exist in the response epee chokes. This fixes it to make it silently ignore it (and leave the array values untouched), which just makes it consistent with what it does for any other type of field. This is particularly needed to be able to retrieve service_node_info with the `service_node_version`, `lokinet_version`, and `storage_server_version` fields omitted without getting a deserialization failure from the omission.
E.g.:
[wallet T6TSSZ (has locked stakes)]: balance
Currently selected account: [0] Primary account
Tag: (No tag assigned)
Balance: 73541.719401728, unlocked balance: 72339.332202963 (23 block(s) to unlock)
Total staked: 919.987654321, 0.000000000 unlocking
Pending SN rewards: 49.419920278, (next payout: block 10433, in about 26 minutes)
jagerman
force-pushed
the
wallet2-batching
branch
from
9448cc9 to
f487aff
Compare
tewinget
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds detail to the balance command of the CLI wallet to show how
much has been batched for each address and also summarises when the next
payout is.