Additional invite/promotion state and missing C functions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpretty-cyro
commented
Jul 17, 2024
mpretty-cyro
commented
- Added an 'INVITE_NOT_SENT' status which is the default used when creating a new group member
- Added a groups_keys_free function to the C API
- Added a groups_keys_storage_namespace function to the C API
- Updated the promotion functions based on the new status options
• Added an 'INVITE_NOT_SENT' status which is the default used when creating a new group memeber • Added a groups_keys_free function to the C API • Added a groups_keys_storage_namespace function to the C API • Updated the promotion functions based on the new status options
simophin
reviewed
Jul 17, 2024
Bilb
reviewed
Jul 17, 2024
jagerman
added a commit
to mpretty-cyro/libsession-util
that referenced
this pull request
Jul 17, 2024
(There are other similar deleters that need freeing that should come once this gets rebased with / merged with PR oxen-io#92).
These were meant to delete the internal C++ object, but weren't actually doing so, and thus would be leaking the C++ objects when supposedly being freed from the C API. Also adds a missing `onion_request_builder_free` function and removes the (wrong) doc implying that `onion_request_builder_build` frees the object.
jagerman
force-pushed
the
new-invite-status
branch
from
7d32558 to
bb392c3
Compare
jagerman
reviewed
Jul 17, 2024
jagerman
reviewed
Jul 17, 2024
jagerman
reviewed
Jul 17, 2024
jagerman
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.