Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): just submodules update transformer test fixtures #7893

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 14, 2024

just submodules run just update-transformer-fixtures. Otherwise after updating submodules, transformer tests will break. Most people won't know that they need to run just update-transformer-fixtures too.

Also make just update-transformer-fixtures work on Windows.

@github-actions github-actions bot added the C-bug Category - Bug label Dec 14, 2024
Copy link
Contributor Author

overlookmotel commented Dec 14, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review December 14, 2024 15:27
@overlookmotel overlookmotel requested a review from Boshen December 14, 2024 15:28
@overlookmotel overlookmotel changed the base branch from 12-14-test_transformer_make_update_fixtures_script_.mjs_ to graphite-base/7893 December 14, 2024 15:29
@overlookmotel overlookmotel force-pushed the 12-14-fix_tools_just_submodules_update_transformer_test_fixtures branch from 5af708a to 468a421 Compare December 14, 2024 15:33
@overlookmotel overlookmotel changed the base branch from graphite-base/7893 to main December 14, 2024 15:34
@overlookmotel overlookmotel force-pushed the 12-14-fix_tools_just_submodules_update_transformer_test_fixtures branch from 468a421 to 2da84b6 Compare December 14, 2024 15:34
@Boshen
Copy link
Member

Boshen commented Dec 14, 2024

No, that command is only for updating submodules, make it run before conformance test please.

@Boshen Boshen closed this Dec 14, 2024
@overlookmotel
Copy link
Contributor Author

No, that command is only for updating submodules, make it run before conformance test please.

We could, but that would slow down transformer conformance. The update script only needs to run once after submodules are updated, and then the changes the script makes just sit there unchanged.

The script used to need to be run more often, but Dunqing fixed that in #7771.

Does that make any sense?

@Boshen Boshen reopened this Dec 16, 2024
@Boshen
Copy link
Member

Boshen commented Dec 16, 2024

Task orchestration is harder than I thought, merge until I figure out how to make this better.

@Boshen Boshen merged commit d94923d into main Dec 16, 2024
15 checks passed
@Boshen Boshen deleted the 12-14-fix_tools_just_submodules_update_transformer_test_fixtures branch December 16, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants