Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tasks/transform-conformance): update only when the output differs from the original output #7779

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore(tasks/transform-conformance): update only when the output differs from the original output #7779

merged 1 commit into from
Dec 11, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 10, 2024 •
edited
Loading

From 5xx files changed to 3xx

This was referenced Dec 10, 2024
Merged
Merged
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing marked this pull request as ready for review December 10, 2024 16:21
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Dec 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 10, 2024
@Dunqing Dunqing force-pushed the 12-10-chore_tasks_transform-conformance_support_--override_flag branch from b25fc44 to 32d2d53 Compare December 10, 2024 23:01
@Dunqing Dunqing force-pushed the 12-11-chore_tasks_transform-conformance_update_only_when_the_output_differs_from_the_original_output branch from 9891385 to 05bba77 Compare December 10, 2024 23:02
@overlookmotel overlookmotel force-pushed the 12-10-chore_tasks_transform-conformance_support_--override_flag branch from 32d2d53 to be99ed7 Compare December 11, 2024 16:00
@overlookmotel overlookmotel force-pushed the 12-11-chore_tasks_transform-conformance_update_only_when_the_output_differs_from_the_original_output branch from 6906859 to 21a9ae8 Compare December 11, 2024 16:01
@overlookmotel overlookmotel mentioned this pull request Dec 11, 2024
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 11, 2024
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Dec 11, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 11, 11:06 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 11, 11:08 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 11, 11:30 AM EST: A user merged this pull request with the Graphite merge queue.

overlookmotel
overlookmotel approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@overlookmotel overlookmotel force-pushed the 12-10-chore_tasks_transform-conformance_support_--override_flag branch from be99ed7 to fcaf65a Compare December 11, 2024 16:12
@overlookmotel overlookmotel force-pushed the 12-11-chore_tasks_transform-conformance_update_only_when_the_output_differs_from_the_original_output branch from 21a9ae8 to 5296643 Compare December 11, 2024 16:13
@overlookmotel overlookmotel changed the base branch from 12-10-chore_tasks_transform-conformance_support_--override_flag to graphite-base/7779 December 11, 2024 16:19
@graphite-app graphite-app bot changed the base branch from graphite-base/7779 to main December 11, 2024 16:25
@Dunqing
chore(tasks/transform-conformance): update only when the output diffe…
74bf141 
…rs from the original output (#7779)

From `5xx` files changed to `3xx`
@overlookmotel overlookmotel force-pushed the 12-11-chore_tasks_transform-conformance_update_only_when_the_output_differs_from_the_original_output branch from 5296643 to 74bf141 Compare December 11, 2024 16:26
@graphite-app graphite-app bot merged commit 74bf141 into main Dec 11, 2024
15 checks passed
@graphite-app graphite-app bot deleted the 12-11-chore_tasks_transform-conformance_update_only_when_the_output_differs_from_the_original_output branch December 11, 2024 16:30
@overlookmotel overlookmotel mentioned this pull request Dec 11, 2024
Merged
Dunqing pushed a commit that referenced this pull request Dec 12, 2024
@overlookmotel
test(transformer): remove dead code from fixtures update script (#7808)
d14d360 
Follow-up after #7771 and #7779. Remove dead code from transformer fixtures updater script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @overlookmotel