Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer/class-properties): add output.js files to override fixtures #7777

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 10, 2024

In two of the overridden text fixtures for class properties transform, there was no output.js file because what was overridden was just options.json and update_fixtures.js script then generated new output files using Babel with the new options.

That was fine, but doesn't work with #7771. So add output.js files to the these overrides too.

Copy link

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 10, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review December 10, 2024 15:18
@overlookmotel
Copy link
Contributor Author

Merging. @Dunqing for your information.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
Copy link
Contributor Author

overlookmotel commented Dec 10, 2024

Merge activity

  • Dec 10, 10:24 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 10, 10:25 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 10, 10:29 AM EST: A user merged this pull request with the Graphite merge queue.

… fixtures (#7777)

In two of the overridden text fixtures for class properties transform, there was no `output.js` file because what was overridden was just `options.json` and `update_fixtures.js` script then generated new output files using Babel with the new options.

That was fine, but doesn't work with #7771. So add `output.js` files to the these overrides too.
@overlookmotel overlookmotel force-pushed the 12-10-test_transformer_class-properties_add_output.js_files_to_override_fixtures branch from 5dcc630 to 4f1ab49 Compare December 10, 2024 15:25
@graphite-app graphite-app bot merged commit 4f1ab49 into main Dec 10, 2024
15 checks passed
@graphite-app graphite-app bot deleted the 12-10-test_transformer_class-properties_add_output.js_files_to_override_fixtures branch December 10, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant