Revert "fix(isolated_declarations): Always emit module declarations (#4911)" #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Merge activity
|
…4911)" (#4916) This reverts commit 0fb0b71. test failed https://github.com/oxc-project/oxc/actions/runs/10405198969/job/28815418191 We should only emit for ```ts declare module "xx" {} declare global {} ``` Do not emit for ```ts module x {} declare module x {} ``` @MichaelMitchell-at cc
Dunqing
force-pushed
the
revert-4911-module_declaration
branch
from
cd53cbe to
46fb3cb
Compare
CodSpeed Performance ReportMerging #4916 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0fb0b71.
test failed https://github.com/oxc-project/oxc/actions/runs/10405198969/job/28815418191
We should only emit for
Do not emit for
@MichaelMitchell-at cc