-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_codegen): replace ///@@
with ///@@line_break
#4786
refactor(ast_codegen): replace ///@@
with ///@@line_break
#4786
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
It is really weird that the line break happens at the end😕 But I guess this one is a bit more clear. |
///@@
with ///@@line_break
///@@
with ///@@line_break
CodSpeed Performance ReportMerging #4786 will not alter performanceComparing Summary
|
How do you mean "at the end"? |
b428568
to
875a9cb
Compare
ba53404
to
7bbde41
Compare
In the sense that it can't be a free-standing thing, It needs to come before an item so we can't have stuff at the end of a scope. |
Merge activity
|
Follow-on after #4778. `///@@line_break` is more verbose, but it's clearer what it does.
875a9cb
to
ec82a79
Compare
7bbde41
to
92777d0
Compare
Ah I see. Yes it is a bit weird. Annoying that there seems to be no way to do something as simple as line breaks without all these odd workarounds. |
Follow-on after #4778.
///@@line_break
is more verbose, but it's clearer what it does.