Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(codegen): split line offsets table into 2 parts #4648

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Aug 5, 2024

WIP

Copy link

graphite-app bot commented Aug 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-codegen Area - Code Generation label Aug 5, 2024
Copy link

codspeed-hq bot commented Aug 5, 2024

CodSpeed Performance Report

Merging #4648 will not alter performance

Comparing 08-05-perf_codegen_split_line_offsets_table_into_2_parts (f2604f7) with 08-05-perf_codegen_reduce_size_of_lineoffsettable_ (150ccb0)

Summary

✅ 32 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-05-perf_codegen_reduce_size_of_lineoffsettable_ branch from 150ccb0 to f961b5c Compare August 5, 2024 23:49
@overlookmotel
Copy link
Contributor Author

Have merged these changes into #4643.

@Boshen Boshen deleted the 08-05-perf_codegen_split_line_offsets_table_into_2_parts branch November 21, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant