Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(sourcemap): reduce string copying in ConcatSourceMapBuilder #4638

Merged
merged 1 commit into from
Aug 5, 2024
Merged

perf(sourcemap): reduce string copying in ConcatSourceMapBuilder #4638

merged 1 commit into from
Aug 5, 2024

Commits on Aug 5, 2024

  1. perf(sourcemap): reduce string copying in ConcatSourceMapBuilder (#… 

    …4638)

Clone `Arc<str>`s for source text instead of creating new `Arc<str>`s and copying the string data.

For the shorter strings (names and source filenames) it's cheaper to create a new `Arc<str>` than to clone, presumably because of the overhead of atomic operations involved in `Arc::clone`.
    @overlookmotel
    overlookmotel committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a330773 View commit details
    Browse the repository at this point in the history