Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): abstract passes and generators behind Runner trait. #4556

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 30, 2024

No description provided.

Copy link

codspeed-hq bot commented Jul 30, 2024

CodSpeed Performance Report

Merging #4556 will not alter performance

Comparing 07-30-refactor_ast_codegen_abstract_passes_and_generators_behind_runner_trait (f39e759) with main (452e0ee)

Summary

✅ 32 untouched benchmarks

@rzvxa rzvxa force-pushed the 07-30-fix_ast_codegen_create_output_path_if_doesn_t_exist branch from a5c36b2 to 38ab21d Compare July 30, 2024 20:34
@rzvxa rzvxa force-pushed the 07-30-refactor_ast_codegen_abstract_passes_and_generators_behind_runner_trait branch from 10d992e to e822ba6 Compare July 30, 2024 20:34
@rzvxa rzvxa force-pushed the 07-30-fix_ast_codegen_create_output_path_if_doesn_t_exist branch from 38ab21d to 9aa6953 Compare July 30, 2024 21:13
@rzvxa rzvxa force-pushed the 07-30-refactor_ast_codegen_abstract_passes_and_generators_behind_runner_trait branch from e822ba6 to 425f59c Compare July 30, 2024 21:13
@rzvxa rzvxa force-pushed the 07-30-fix_ast_codegen_create_output_path_if_doesn_t_exist branch from 9aa6953 to c08d405 Compare July 30, 2024 21:48
@rzvxa rzvxa force-pushed the 07-30-refactor_ast_codegen_abstract_passes_and_generators_behind_runner_trait branch from 425f59c to c4345a1 Compare July 30, 2024 21:48
@rzvxa rzvxa marked this pull request as ready for review August 1, 2024 23:15
@rzvxa
Copy link
Contributor Author

rzvxa commented Aug 1, 2024

@overlookmotel These 3 are also ready to be reviewed. The last PR is also for review, But not ready to be merged.

Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I'm not on top of everything codegen is doing / how it's working, so hard for me to review in full. But if you're happy with this, please go ahead and merge.

@rzvxa rzvxa force-pushed the 07-30-fix_ast_codegen_create_output_path_if_doesn_t_exist branch from c08d405 to 0151aff Compare August 1, 2024 23:53
@rzvxa rzvxa force-pushed the 07-30-refactor_ast_codegen_abstract_passes_and_generators_behind_runner_trait branch from c4345a1 to 7106360 Compare August 1, 2024 23:53
Copy link

graphite-app bot commented Aug 2, 2024

Merge activity

@rzvxa rzvxa force-pushed the 07-30-fix_ast_codegen_create_output_path_if_doesn_t_exist branch from 0151aff to abc8836 Compare August 2, 2024 00:11
@rzvxa rzvxa force-pushed the 07-30-refactor_ast_codegen_abstract_passes_and_generators_behind_runner_trait branch from 7106360 to f39e759 Compare August 2, 2024 00:12
@rzvxa rzvxa changed the base branch from 07-30-fix_ast_codegen_create_output_path_if_doesn_t_exist to main August 2, 2024 00:20
@graphite-app graphite-app bot merged commit f39e759 into main Aug 2, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 07-30-refactor_ast_codegen_abstract_passes_and_generators_behind_runner_trait branch August 2, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants