Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(sourcemap): speed up encoding mappings #4492

Closed

Conversation

overlookmotel
Copy link
Contributor

No description provided.

Copy link

graphite-app bot commented Jul 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Jul 26, 2024

CodSpeed Performance Report

Merging #4492 will not alter performance

Comparing 07-26-perf_sourcemap_speed_up_encoding_mappings (a02c47c) with main (5db7bed)

Summary

✅ 32 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 07-26-perf_sourcemap_speed_up_encoding_mappings branch from 1940532 to d75040b Compare July 26, 2024 18:34
@Boshen Boshen force-pushed the 07-26-fix_sourcemap_fix_pre-calculation_of_required_segments_for_building_json branch from b1d023d to 5db7bed Compare July 27, 2024 10:26
@Boshen Boshen changed the base branch from 07-26-fix_sourcemap_fix_pre-calculation_of_required_segments_for_building_json to main July 27, 2024 10:32
@Boshen Boshen force-pushed the 07-26-perf_sourcemap_speed_up_encoding_mappings branch from bb5b30b to a02c47c Compare July 27, 2024 10:32
@overlookmotel
Copy link
Contributor Author

No appreciable change on benchmarks, so it's not worth the unsafe code. Have pulled out aligning the base64 lookup table into a separate PR #4535.

@Boshen Boshen deleted the 07-26-perf_sourcemap_speed_up_encoding_mappings branch August 12, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant