New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(semantic): populate `declarations` field in `SymbolTable::create_symbol` #4461

Merged

graphite-app merged 1 commit into main from 07-25-refactor_semantic_populate_declarations_field_in_symboltable_create_symbol_

Jul 26, 2024

Commits on Jul 26, 2024

refactor(semantic): populate declarations field in `SymbolTable::cr…

…eate_symbol` (#4461)

`declarations` field of `SymbolTable` is part of SoA group, where all `Vec`s in the group are indexed by `SymbolId`. Populate `declarations` field along with the rest in `create_symbol`, to prevent them getting out of sync. This will prevent bugs like the one fixed in #4460.

overlookmotel committed Jul 26, 2024