Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(semantic): reduce AstNodeId to u32 #4264

Merged
merged 1 commit into from
Jul 15, 2024
Merged

perf(semantic): reduce AstNodeId to u32 #4264

merged 1 commit into from
Jul 15, 2024

Commits on Jul 15, 2024

  1. perf(semantic): reduce AstNodeId to u32 (#4264) 

    `AstNodeId` was a `usize`. This seems excessive.

Parser has a limit on size of a JS file of 4 GiB. While it is *possible* for a JS file of that size to create an AST with more than `1 << 32` (~4 billion) AST nodes, that would be insanely large.

So make `AstNodeId` `u32` instead.
    @overlookmotel
    overlookmotel committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8fad7db View commit details
    Browse the repository at this point in the history