Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): fix tests for number parsing #4254

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix(parser): fix tests for number parsing #4254

merged 1 commit into from
Jul 15, 2024

Commits on Jul 15, 2024

  1. fix(parser): fix tests for number parsing (#4254) 

    Fix tests for parsing large numbers.

* Tests for imprecision decimals and octals weren't using numbers larger than `u64::MAX`, so were not testing what they were meant to be - that parser can handle larger numbers.
* Tests for decimals (e.g. `123.5`) were calling `parse_int` which isn't meant to handle that (`parse_float` does that).
* Tests were calling `parse_int` with negative numbers, which it's not meant to handle.

Also, re-order the const assertions in same order as the code above.
    @overlookmotel
    overlookmotel committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    641a78b View commit details
    Browse the repository at this point in the history