Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: false positive in eslint-plugin-jest(valid-title) rule #8531

Closed
baseballyama opened this issue Jan 16, 2025 · 1 comment · Fixed by #8589
Closed

linter: false positive in eslint-plugin-jest(valid-title) rule #8531

baseballyama opened this issue Jan 16, 2025 · 1 comment · Fixed by #8589
Labels
A-linter Area - Linter C-bug Category - Bug

Comments

@baseballyama
Copy link
Contributor

baseballyama commented Jan 16, 2025

What version of Oxlint are you using?

0.15.6

What command did you run?

oxlint -c=../../../.oxlintrc.json

What does your .oxlint.json config file look like?

{
  "$schema": "./node_modules/oxlint/configuration_schema.json",
  "categories": {
    "correctness": "error"
  },
  "plugins": ["typescript", "unicorn", "oxc", "security", "jsdoc", "n", "vitest"],
  "env": {},
  "settings": {},
  "rules": {
    "eqeqeq": ["error", "always", { "null": "ignore" }],
    "vitest/expect-expect": "off",
    "vitest/no-disabled-tests": "off",
    "vitest/no-conditional-expect": "off",
    "jest/no-standalone-expect": "off",
    "jest/no-export": "off",
    "no-document-cookie": "off",
    "no-unused-vars": "off"
  },
  "overrides": [
    {
      "files": ["*.svelte"],
      "rules": {
        "no-unused-vars": "off"
      }
    }
  ]
}

What happened?

The type of testCase is string, but this error occurred.
I think we need to implement the configs provided by eslint-plugin-vitest.
https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/valid-title.md

image

@baseballyama baseballyama added A-linter Area - Linter C-bug Category - Bug labels Jan 16, 2025
@shulaoda
Copy link
Contributor

In fact, vitest/valid-title also has this issue.

camc314 pushed a commit that referenced this issue Jan 18, 2025
…8589)

closes #8531 

I'm not sure if we should support it because both `vitest` and `jest`
have this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants