Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove methods from Semantic #4170

Closed
overlookmotel opened this issue Jul 10, 2024 · 2 comments · Fixed by #4193
Closed

Remove methods from Semantic #4170

overlookmotel opened this issue Jul 10, 2024 · 2 comments · Fixed by #4193
Labels
C-enhancement Category - New feature or request

Comments

@overlookmotel
Copy link
Contributor

overlookmotel commented Jul 10, 2024 •
edited
Loading

#4168 changed Visit to pass &scope_id into enter_scope. We can now refactor Semantic to write to scope_id fields in enter_scope. After that, we can remove some visitor methods from Semantic (as Dunqing pointed out).
@overlookmotel overlookmotel added the C-bug Category - Bug label Jul 10, 2024
@rzvxa rzvxa added C-enhancement Category - New feature or request and removed C-bug Category - Bug labels Jul 10, 2024
@Dunqing Dunqing mentioned this issue Jul 11, 2024
Merged
Boshen pushed a commit that referenced this issue Jul 11, 2024
@Dunqing
refactor(semantic): set current_scope_id to scope_id in `enter_sc…
bbe5ded 
…ope` (#4193)

close: #4170
@overlookmotel
Copy link
Contributor Author

Fixed in #4193.

@Boshen Do you know why issues don't get automatically closed when PRs are merged? It's a bit annoying.

@Dunqing
Copy link
Member

Dunqing commented Jul 11, 2024

Fixed in #4193.

@Boshen Do you know why issues don't get automatically closed when PRs are merged? It's a bit annoying.

I've mentioned this problem before, and it seems to be due to a merge caused by Graphite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(semantic): set current_scope_id to scope_id in enter_scope oxc-project/oxc
3 participants
@overlookmotel @rzvxa @Dunqing