fix(semantic): params in export default (function() {}) flagged as Sy…

…mbolFlags::Export
oxc-project · Jul 26, 2024 · 8644ba9 · 8644ba9
1 parent 42a2519
commit 8644ba9
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 4 deletions.
diff --git a/crates/oxc_semantic/src/builder.rs b/crates/oxc_semantic/src/builder.rs
@@ -1675,7 +1675,7 @@ impl<'a> SemanticBuilder<'a> {
                         func.id.is_some()
                     }
                     ExportDefaultDeclarationKind::ClassDeclaration(ref class) => class.id.is_some(),
-                    _ => true,
+                    _ => false,
                 } {
                     self.current_symbol_flags |= SymbolFlags::Export;
                 }

diff --git a/crates/oxc_semantic/tests/integration/symbols.rs b/crates/oxc_semantic/tests/integration/symbols.rs
@@ -133,12 +133,19 @@ fn test_export_flag() {
         class b {}
         export default c;
         function c() {}
+
+        export default (function funcExpr() {});
+        export default (function(param) {});
+
     ",
     );
 
-    tester.has_root_symbol("a").contains_flags(SymbolFlags::Export).test();
-    tester.has_root_symbol("b").contains_flags(SymbolFlags::Export).test();
-    tester.has_root_symbol("c").contains_flags(SymbolFlags::Export).test();
+    tester.has_root_symbol("a").is_exported().test();
+    tester.has_root_symbol("b").is_exported().test();
+    tester.has_root_symbol("c").is_exported().test();
+
+    tester.has_symbol("funcExpr").is_not_exported().test();
+    tester.has_symbol("param").is_not_exported().test();
 }
 
 #[test]

diff --git a/crates/oxc_semantic/tests/integration/util/symbol_tester.rs b/crates/oxc_semantic/tests/integration/util/symbol_tester.rs
@@ -137,6 +137,25 @@ impl<'a> SymbolTester<'a> {
         self
     }
 
+    /// Checks if the resolved symbol does not contain any flags in `flags`, using ! [`SymbolFlags::contains()`]
+    pub fn does_not_contain_flags(mut self, flags: SymbolFlags) -> Self {
+        self.test_result = match self.test_result {
+            Ok(symbol_id) => {
+                let found_flags = self.semantic.symbols().get_flag(symbol_id);
+                if !found_flags.contains(flags) {
+                    Ok(symbol_id)
+                } else {
+                    Err(OxcDiagnostic::error(format!(
+                        "Expected {} to not contain flags {:?}, but it had {:?}",
+                        self.target_symbol_name, flags, found_flags
+                    )))
+                }
+            }
+            err => err,
+        };
+        self
+    }
+
     pub fn intersects_flags(mut self, flags: SymbolFlags) -> Self {
         self.test_result = match self.test_result {
             Ok(symbol_id) => {