Skip to content

Commit

Permalink
fix(transformer): unexpectedly removed class binding from ExportNamed…
Browse files Browse the repository at this point in the history
…Declaration
  • Loading branch information
Dunqing committed Jul 18, 2024
1 parent 7d75189 commit 678a8d9
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 12 deletions.
10 changes: 5 additions & 5 deletions crates/oxc_semantic/src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -399,12 +399,12 @@ impl<'a> SemanticBuilder<'a> {
resolved_references.reserve(references.len());

references.retain(|(id, flag)| {
if flag.is_type() && symbol_flag.is_can_be_referenced_by_type()
|| flag.is_value() && symbol_flag.is_value()
if flag.is_type() && symbol_flag.can_be_referenced_by_type()
|| flag.is_value() && symbol_flag.can_be_referenced_by_value()
{
// The non type-only ExportSpecifier can reference a type,
// If the reference is not a type, remove the type flag from the reference
if !symbol_flag.is_type() && !flag.is_type_only() {
// The non type-only ExportSpecifier can reference a type/value symbol,
// If the symbol is a value symbol and reference flag is not type-only, remove the type flag.
if symbol_flag.is_value() && !flag.is_type_only() {
*self.symbols.references[*id].flag_mut() -= ReferenceFlag::Type;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/export/named-du
"node": "VariableDeclarator",
"references": [
{
"flag": "ReferenceFlag(Read | Type)",
"flag": "ReferenceFlag(Read)",
"id": 0,
"name": "T",
"node_id": 12
Expand Down
18 changes: 13 additions & 5 deletions crates/oxc_syntax/src/symbol.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,12 @@ impl SymbolFlags {
self.intersects(Self::Variable)
}

/// If true, then the symbol is a type, such as a TypeAlias, Interface, or Enum
pub fn is_type(&self) -> bool {
self.intersects(Self::Type | Self::TypeImport)
}

pub fn is_can_be_referenced_by_type(&self) -> bool {
self.is_type() || self.contains(Self::Import)
self.intersects((Self::TypeImport | Self::Type) - Self::Value)
}

/// If true, then the symbol is a value, such as a Variable, Function, or Class
pub fn is_value(&self) -> bool {
self.intersects(Self::Value | Self::Import | Self::Function)
}
Expand Down Expand Up @@ -133,4 +131,14 @@ impl SymbolFlags {
pub fn is_import(&self) -> bool {
self.intersects(Self::Import | Self::TypeImport)
}

/// If true, then the symbol can be referenced by a type
pub fn can_be_referenced_by_type(&self) -> bool {
self.intersects(Self::Type | Self::TypeImport | Self::Import)
}

/// If true, then the symbol can be referenced by a value
pub fn can_be_referenced_by_value(&self) -> bool {
self.intersects(Self::Value | Self::Import | Self::Function)
}
}
2 changes: 1 addition & 1 deletion tasks/transform_conformance/oxc.snap.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
commit: 12619ffe

Passed: 6/6
Passed: 7/7

# All Passed:
* babel-plugin-transform-typescript
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Foo {}
const Bar = 0;
function Func() {}
type Baz = any;
interface Baq {}

export { Foo, Func, Bar, Baz, Baq };
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
class Foo {}
const Bar = 0;
function Func() {}
export { Foo, Func, Bar };

0 comments on commit 678a8d9

Please sign in to comment.