Fix unterminated quoted string bug #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owtaylor
reviewed
Feb 24, 2022
code.sh
Outdated
| @@ -298,7 +298,7 @@ fi | |||
| # different toolboxes step on each other. | |||
|
|
|||
| homevar="$(flatpak-spawn --host podman inspect "$container_name" \ | |||
| --format='{{ range .Config.Env }}{{ . }}{{"\n"}}{{ end }}' \ | |||
| --format='{{ range .Config.Env }}{{ . }}\n{{ end }}' \ | |||
There was a problem hiding this comment.
If I try this with podman-3.4.4 from Fedora 35, I simply get literal "\n" in the output instead of newlines.
There was a problem hiding this comment.
I tested with 35 and updated pull-request. See how does it now.
|
The test failures seem to mostly (completely?) be because the tests have various hardcoded expectations on the podman command and haven't been updated. |
|
I'd really like a bug filed against libpod and to see their response before I proceed here, We can work around bugs in podman, but I don't want to blindly work around bugs in libpod. |
|
Fixed bracket typo, should be OK now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #21