Handle when $HOME for the container is not /root #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio Code uses HOME from the container config to determine where it puts .vscode-server. Toolboxes created with older versions of toolbox+podman have HOME=/root, but with newer versions, we might end up with HOME=/var/home/<user> or HOME=/. Handle all these cases. In particular for the user-home-directory case, put a symlink from /var/home/<user>/.vscode-server => /.vscode-server to make sure that the configuration is properly per-container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio Code uses HOME from the container config to determine
where it puts .vscode-server. Toolboxes created with older versions of
toolbox+podman have HOME=/root, but with newer versions, we might end up with
HOME=/var/home/ or HOME=/.
Handle all these cases. In particular for the user-home-directory case,
put a symlink from /var/home//.vscode-server => /.vscode-server
to make sure that the configuration is properly per-container.